[appservice] Surface Kudu 409 response body in az webapp webjob triggered list - #33825
[appservice] Surface Kudu 409 response body in az webapp webjob triggered list#33825Aditya Pujara (a0x1ab) with Copilot wants to merge 6 commits into
az webapp webjob triggered list#33825Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
webapp |
az webapp webjob triggered list
Live test results —
|
There was a problem hiding this comment.
CI Failure Summary — PR #33825
The following checks failed on the latest commit (3a433def5ef1dd2e5b98505c6a29077d0c5c67b0):
- Azure.azure-cli (build) — failed
- Azure.azure-cli (Check CLI Style) — failed
Both failures stem from the same root cause, a pylint style violation:
ERROR: ************* Module azure.cli.command_modules.appservice.custom
src/azure-cli/azure/cli/command_modules/appservice/custom.py:10453:4: W0621: Redefining name 'json' from outer scope (line 20) (redefined-outer-name)
src/azure-cli/azure/cli/command_modules/appservice/custom.py:10453:4: W0404: Reimport 'json' (imported line 20) (reimported)
json is already imported at module scope (line 20 of src/azure-cli/azure/cli/command_modules/appservice/custom.py). The code added at line 10453 re-imports json locally inside a function, which is unnecessary and triggers both redefined-outer-name and reimported pylint errors.
Fix needed: remove the local/inner import json statement at line 10453 in src/azure-cli/azure/cli/command_modules/appservice/custom.py (the module-level import at the top of the file already covers it). After removing it, run azdev style appservice locally to confirm the style check passes, then push the fix.
Posted by agent-assist (autonomous bug-fix pipeline).
|
Copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33825 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
Fixed in the latest commit. The CI failures were caused by a redundant |
Live test results —
|
There was a problem hiding this comment.
✅ All checks passed
Live tests passed and all CI checks are green. This PR is ready for human review.
Posted by agent-assist (autonomous bug-fix pipeline).
There was a problem hiding this comment.
Copilot finished without pushing a fix after 3 automated attempts for the feedback at #33825 (comment). Leaving this PR for manual follow-up.
Posted by agent-assist (autonomous bug-fix pipeline).
… and add regression test Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Live test results —
|
Live test results —
|
There was a problem hiding this comment.
✅ Review Summary — All Checks Passed
PR: #33825 — [appservice] Surface Kudu 409 response body in \az webapp webjob triggered list``
Head SHA: 58068c4f0fd1c37eb6304c0b552123e45a9736e7
Results
- CI checks: 20/20 passed, 0 failed, 0 pending
- Live test (azdev --live): ✅ success (run)
Everything is green for this head commit. No further automated action needed at this time — ready for human review/merge decision.
Posted by agent-assist (autonomous bug-fix pipeline).
|
Copilot The lazy-pager change at head Live retest in Demo Three Subscription: The new The remaining problem is Please decode the production response shape safely so the CLI emits only the actionable service message: Please also update the test to model the live encoded body and assert the exact clean message. Keep the lazy-iteration test and successful pager behavior. |
|
Started a Copilot task using Posted by agent-assist (autonomous bug-fix pipeline). |
…rors Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Fixed in the latest commit. |
Live test results —
|
|
Approved from my side. I retested head |
|
Started a Copilot task using Posted by agent-assist (autonomous bug-fix pipeline). |
|
Started a Copilot task using Posted by agent-assist (autonomous bug-fix pipeline). |
|
Started a Copilot task using Posted by agent-assist (autonomous bug-fix pipeline). |
There was a problem hiding this comment.
Copilot finished without pushing a fix after 3 automated attempts for the feedback at #33825 (comment). Leaving this PR for manual follow-up.
Posted by agent-assist (autonomous bug-fix pipeline).
|
🔔 Routing this PR to @Azure/act-observability-squad. |
Related command
az webapp webjob triggered listDescription
When Kudu returns
409 Conflict(e.g.webJobsEnabled=falseon the site config), the Azure SDK raisesHttpResponseErrorwith only the HTTP status phrase, discarding the actionable response body:{"error": "The web app is not configured to run the web job. Please enable running web jobs before calling the API."}Previously the CLI emitted only
Operation returned an invalid status 'Conflict'.Fix:
list_triggered_webjobsnow catchesHttpResponseErrorwithstatus_code == 409, parses the Kudu JSON body, and raisesUnclassifiedUserFaultwith the extractederrorstringstr(ex)if the body is absent or not valid JSONTesting Guide
New unit tests in
test_webapp_commands_thru_mock.py::TestListTriggeredWebjobs:# Run the targeted mock tests python -m pytest src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands_thru_mock.py::TestListTriggeredWebjobs -vThree cases covered:
UnclassifiedUserFaultwith the extracted messageHttpResponseError→ re-raised as-isUnclassifiedUserFaultwith fallback stringHistory Notes
[appservice]
az webapp webjob triggered list: Surface Kudu error body on HTTP 409 Conflict instead of generic status phraseThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.