realign available MCP functions - #29
Open
Lei Jiang (lionelc) wants to merge 1 commit into
Open
Lei Jiang (lionelc) wants to merge 1 commit into
Lei Jiang (lionelc) wants to merge 1 commit into
Conversation
Collaborator
Skill review:
|
| Level | What loads | Tokens | % of 200k |
|---|---|---|---|
| L1 — always loaded | frontmatter every turn | 121 | 0.06% |
| L2 — on invocation | SKILL.md body | 2,277 | 1.14% |
| L3 — on demand | references (both, summed) | 2,564 | 1.28% |
| Full load | everything | 4,962 | 2.48% |
SKILL.md is 278 lines (under the 500-line ceiling).
🔴 Blockers
- none — no reference frontmatter, no PR-introduced broken links, body within limits.
🟡 Improvements
SKILL.mdStep 2 (lines ~162–163): Stale leftover from the rename. It still tells the agent to extractindexes_stats(usage frequency) andcollection_stats(doc count, avg size) "from theexplain("executionStats")response." Those fields came from the old bundledoptimize_find_query; rawexplain_operation/.explain()does not return them — they now require a separateget_statisticscall. Internally inconsistent with this PR's own change.SKILL.md"MCP Tools Available" table:current_ops(andcreate_index/drop_index) aremanagementtools. The kit'smcp.jsonshipsENABLE_MANAGEMENT_TOOLS=false, so they are not available under the default profile. The table listscurrent_opsas plainly available with no gate note.- Cross-skill (out of this PR's scope):
skills/natural-language-querying/SKILL.mdstill references the non-existentget_db_info. The same cleanup applied here should extend there.
🟢 Strengths
- Central claim holds: every retained tool name verifies against upstream; every removed one is genuinely absent. Clean, correct realignment.
- Adding mongosh equivalents for each MCP tool is a real improvement — gives the skill a working path when MCP isn't connected or management tools are gated off.
- Short spine + on-demand references preserved; architecture cost stays ~1.1% on invocation.
Recommended next step
Fix the Step 2 stale collection_stats/indexes_stats reference (point it at get_statistics) and add a one-line management-gate note for current_ops, then ship.
🤖 Generated with skill-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-maps the MCP functions used in agent-kit and only picks those really appearing in documentdb-mcp. So it's a clean-up PR.