feat: opt-in install scripts with anonymous usage telemetry - #30
Closed
Ritvik Jayaswal (Ritvik-Jayaswal) wants to merge 1 commit into
Closed
Ritvik Jayaswal (Ritvik-Jayaswal) wants to merge 1 commit into
Ritvik Jayaswal (Ritvik-Jayaswal) wants to merge 1 commit into
Conversation
Ritvik Jayaswal (Ritvik-Jayaswal)
marked this pull request as draft
July 6, 2026 17:35
Lei Jiang (lionelc)
self-requested a review
July 6, 2026 18:49
Lei Jiang (lionelc)
requested changes
Jul 6, 2026
Lei Jiang (lionelc)
left a comment
Lei Jiang (lionelc)
left a comment
Collaborator
There was a problem hiding this comment.
We need to discuss about the exposed key. In its current form, it can't be merged.
| $KitVersion = '1.0.0' | ||
| # App Insights ingestion key. An instrumentation key is an ingestion-only | ||
| # identifier and is safe to embed in client-side installers. | ||
| $InstrumentationKey = '9c3ca0ad-9326-412b-a325-70acfe2e33e3' |
Collaborator
There was a problem hiding this comment.
Why expose this key to the public? What's the risk?
Add scripts/install.ps1 and scripts/install.sh that install skills and, only when explicitly opted in (-Telemetry/--telemetry or DDBKIT_TELEMETRY=1), send one anonymous skill_install event to Application Insights. Document collection in TELEMETRY.md and reference from README. Telemetry is off by default and never blocks installs.
Ritvik Jayaswal (Ritvik-Jayaswal)
force-pushed
the
feat/optin-usage-telemetry-azure
branch
from
July 6, 2026 19:00
0be809c to
da4ae8d
Compare
Ritvik Jayaswal (Ritvik-Jayaswal)
deleted the
feat/optin-usage-telemetry-azure
branch
July 6, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds cross-platform install scripts that copy/symlink the
skills/folder into an agent's skills directory, with anonymous, opt-in usage telemetry so maintainers can see which skills are actually installed.scripts/install.ps1(Windows/PowerShell)scripts/install.sh(macOS/Linux)TELEMETRY.mddocuments exactly what is / isn't collectedTelemetry
-Telemetry/--telemetryorDDBKIT_TELEMETRY=1.skill_installevent to Application Insights: kit version, target, OS family, install method, list of skill names, skill count, random per-invocation id.Notes