Add child client API version overrides - #5157
Draft
Mark Cowlishaw (markcowl) wants to merge 5 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
microsoft-github-policy-service
Bot
added
lib:azure-resource-manager
Contributor
|
All changed packages have been documented.
Show changes
|
@azure-tools/typespec-autorest
@azure-tools/typespec-azure-resource-manager
@azure-tools/typespec-client-generator-core
@azure-tools/typespec-go
@azure-tools/typespec-ts
commit: |
Contributor
|
You can try these changes here
|
Validate root-client API version overrides while constructing the SDK package so TypeSpec validation does not eagerly build the client graph or duplicate unrelated diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Keep client override validation in the TypeSpec validation hook, but determine explicit client ancestry directly from scoped decorator state so validation does not emit SDK graph diagnostics early or twice. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
microsoft-github-policy-service
Bot
added
the
stale
|
Hi @Mark Cowlishaw (@markcowl). Your PR has had no update for 14 days and it is marked as a stale PR. If it is not updated within 14 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@overrideClientApiVersiondecorator for interface subclientsinfo.versionwhen all operations in a document use one override, with mismatch warnings and explicit ARM feature-file precedenceValidation