feat(tcgc): support overriding method responses - #5173
Open
iscai-msft wants to merge 13 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
iscai-msft
requested review from
Laurent Mazuel (lmazuel),
m-nash,
Mark Cowlishaw (markcowl),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
August 6, 2026 15:06
microsoft-github-policy-service
Bot
added
the
lib:tcgc
added 2 commits
August 6, 2026 11:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
Contributor
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
The following packages have already been documented:
Show changes
|
commit: |
Contributor
|
You can try these changes here
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
Contributor
📦 Package size report4 packages changed size, +10.55 KB (+0.1%) packed overall.
9 package(s) with no notable change
Packed = gzipped |
added 2 commits
August 10, 2026 15:00
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
microsoft-github-policy-service
Bot
added
the
emitter:java
added 3 commits
August 10, 2026 15:15
| name: string; | ||
| } | ||
|
|
||
| @post op create(): Widget | Error; |
There was a problem hiding this comment.
Java does not support union of 2 unrelated models...
Comment on lines
+52
to
+53
| op customizedCreate(): DeleteResult; | ||
| @@override(TestService.create, TestService.customizedCreate); |
There was a problem hiding this comment.
Why is this allowed?
|
|
||
| const baseServiceMethod = diagnostics.pipe( | ||
| getSdkBasicServiceMethod<TServiceOperation>(context, operation, client), | ||
| getSdkBasicServiceMethod<TServiceOperation>(context, operation, client, false), |
There was a problem hiding this comment.
Why here we pass false? This flag looks quick hacky to me.
|
|
||
| @post op create(): Widget; | ||
|
|
||
| op customizedCreate(): DeleteResult; |
There was a problem hiding this comment.
Please pay attention to the usage and serialization info of new response model.
There was a problem hiding this comment.
as well as the usage for original model.
| * ``` | ||
| */ | ||
| #suppress "experimental-feature" "replaceResponse uses extern fn which is experimental but provides essential response transformation functionality" | ||
| extern fn replaceResponse(operation: Reflection.Operation, response: unknown): Reflection.Operation; |
There was a problem hiding this comment.
When we replace the response, how could we know how to map the method level response to the HTTP level response?
Re-applies the fix reverted in 35b427d. Verified this duplicate-body failure is introduced by this PR's pageable/response-override classification changes (confirmed clean compile on main, failing on this branch), not a pre-existing Java fixture bug, so the fix belongs here. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aca8827-bea2-4bf5-ae80-c87bebeedcbd
| op groupExcludeBodyCustomization( | ||
| ...TspTest.MethodOverride.GroupExcludeBody, | ||
| options?: TspTest.MethodOverride.GroupQueryOptions, | ||
| @query options?: TspTest.MethodOverride.GroupQueryOptions, |
There was a problem hiding this comment.
Emm, I am OK if this is only to unblock. But unsure why? What if we group query and header parameter in the model?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3542