Move legacy API version override to Azure Core - #5176
Draft
Mark Cowlishaw (markcowl) wants to merge 6 commits into
Draft
Move legacy API version override to Azure Core#5176Mark Cowlishaw (markcowl) wants to merge 6 commits into
Mark Cowlishaw (markcowl) wants to merge 6 commits into
Conversation
microsoft-github-policy-service
Bot
added
lib:azure-core
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
|
You can try these changes here
|
@azure-tools/typespec-autorest
@azure-tools/typespec-azure-core
@azure-tools/typespec-azure-resource-manager
@azure-tools/typespec-client-generator-core
@azure-tools/typespec-go
@azure-tools/typespec-ts
commit: |
Mark Cowlishaw (markcowl)
force-pushed
the
markcowl/azure-core-override-api-version
branch
from
August 7, 2026 03:10
c964531 to
c6b6218
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Validate root-client API version overrides while constructing the SDK package so TypeSpec validation does not eagerly build the client graph or duplicate unrelated diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Keep client override validation in the TypeSpec validation hook, but determine explicit client ancestry directly from scoped decorator state so validation does not emit SDK graph diagnostics early or twice. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Add Azure.Core.Legacy.overrideApiVersion with inherited accessors and update TCGC and downstream emitters to consume the Azure Core metadata while preserving per-client opaque API-version defaults. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Document Azure.Core.Legacy.overrideApiVersion in the generated Azure Core decorator reference and index. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f21ed198-f6d8-4a45-ab56-25dbec549540
Mark Cowlishaw (markcowl)
force-pushed
the
markcowl/azure-core-override-api-version
branch
from
August 7, 2026 03:14
c6b6218 to
54a2526
Compare
Contributor
📦 Package size report8 packages changed size compared to the base branch.
37 unchanged package(s)
Packed = gzipped |
| export function getApiVersionOverride( | ||
| program: Program, | ||
| target: Namespace | Interface, | ||
| emitterName?: string, |
There was a problem hiding this comment.
No Azure Core decorators have scope. Shall we remove the emitterName?
There was a problem hiding this comment.
You do not need to add new param in TCGC. Just change the logic inner updateWithApiVersionInformation and all emitters could get transparent value for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation