fix(typespec-go): parse text request bodies in fake servers - #5272
Open
Chenjie Shi (tadelesh) wants to merge 3 commits into
Open
fix(typespec-go): parse text request bodies in fake servers#5272Chenjie Shi (tadelesh) wants to merge 3 commits into
Chenjie Shi (tadelesh) wants to merge 3 commits into
Conversation
Follow up on Azure#5238 by converting generated fake-server text bodies back to their declared Go types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 291c8d49-aec6-40e7-95b7-798e6606bf2e
microsoft-github-policy-service
Bot
added
the
emitter:go
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
📦 Package size report2 packages changed size, +2.62 KB (+0.0%) packed overall.
11 package(s) with no notable change
Packed = gzipped |
Contributor
Go emitter diffBaseline Diff summary: 1 file(s), +2 / -1 Rendered diff: inline on the run summary, or the emitter-diff-go-html artifact. Informational check (core/eng/emitter-diff); does not block the PR. |
commit: |
Contributor
|
You can try these changes here
|
Reuse one scalar parser across model decoding, text responses, multipart values, fake parameters, and fake text bodies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 291c8d49-aec6-40e7-95b7-798e6606bf2e
Chenjie Shi (tadelesh)
marked this pull request as draft
August 20, 2026 10:41
Move the existing transport scalar parser into shared helpers and reuse it for fake text request bodies without broadening supported scalar types. Restore model serde and unrelated fake parameter parsing to their prior implementations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 291c8d49-aec6-40e7-95b7-798e6606bf2e
Chenjie Shi (tadelesh)
marked this pull request as ready for review
August 21, 2026 03:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text/plainrequest bodies back into their declared Go wire typesfalse,0, and empty extensible-enum strings by checking request-body presenceFollow-up to #5238.
Validation
go test -run '^$' ./...go test -run '^$' ./...@azure-tools/typespec-goTypeScript build