gantry acr artifact streaming - #836
Draft
Vaibhav Patel (vpatelsj) wants to merge 23 commits into
Draft
Vaibhav Patel (vpatelsj) wants to merge 23 commits into
Vaibhav Patel (vpatelsj) wants to merge 23 commits into
Conversation
Vaibhav Patel (vpatelsj)
changed the title
Six agent knobs were duplicated across the config struct, defaults, env vars, CLI flags, validation, chart values, JSON schema, and the rendered ConfigMap. Four of them were tuning values an operator cannot evaluate from the outside, so keep only the feature gate and the signed-origin host allowlist and move the rest into internal/gantry/streaming beside the behavior they govern. NewOriginClient no longer takes tuning parameters and cannot fail, and streaming.Options now falls back to defaults instead of rejecting a zero value, which removes an error path from agent startup. Also stop writing logConfig.logLevel on the host. The configurator owns p2pConfig only; the test now pins that unrelated OverlayBD settings are left exactly as the host had them.
The live streaming e2e sent sig=redacted, so the plan's secret-free logs contract passed without testing anything. Use a sentinel SAS value and assert it is absent from every Gantry pod's logs and metrics after the request has demonstrably transited the agent.
Add a stale-provider e2e: remove the blob from the provider's containerd while its DHT record survives, then assert the next range fails over to the signed origin inside one request and the peer serves nothing more. libp2p has no protocol-level withdraw, so this is the real production shape rather than a simulated error. Make the test origin reject any request whose URI did not arrive byte-for-byte and give it the ACR data-path form, doubled slash and percent-encoded query included. Raw signed-URL preservation through the real listener was previously only covered by a unit test with a hand-set RequestURI. Factor the shared cluster setup into a fixture so the two scenarios do not duplicate it. Document the operations surface the plan required and was missing: metrics reference, four alert rules separating Gantry, ACR, peer-reuse and allowlist failures, an incident table, and a compatibility matrix naming who owns each component.
Vaibhav Patel (vpatelsj)
force-pushed
the
copilot/gantry-acr-artifact-streaming
branch
from
September 25, 2026 12:06
3d5f410 to
92842e1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.