Skip to content

[AGENT] Fix PR343 media review and MCP findings - #345

Merged
BASIC-BIT merged 6 commits into
mainfrom
codex/pr343-review-followups
Sep 24, 2026
Merged

BASIC-BIT merged 6 commits into
mainfrom
codex/pr343-review-followups

Conversation

@BASIC-BIT

@BASIC-BIT BASIC-BIT commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

[AGENT]

Fixes the twelve technical findings left on PR343. Limited reviewers can no longer replace private media they cannot inspect. That refusal now shows BASIC's approved message, “Only the profile owner or a site admin can approve this replacement.” Identity/dispute restrictions stay scoped to their target profile.

  • Bound new refusal receipts while preserving existing replay and successful admission; expire obsolete host counters and enforce allowance expiry and a single active approval.
  • Validate cleanup configuration before advertising upload readiness.
  • Correct hosted MCP delegation, mixed-append scopes, archive metadata, provenance discovery, and write-outcome recording.

Regression coverage includes the 256-receipt boundary and an oversized historical read, concurrent allowance approvals, private-asset replacement, actual tools/list output, and persisted MCP event records. Local Convex schema initialization and backend health were exercised. The release docs now account for reviews finishing after merge and provider-controlled production aliases.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T02:15:28.671294Z 1ce1355 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The current head appears safe to merge, with the final browser-message correction covering both single and batch media-review refusal displays.

Summary

The PR addresses media-review authorization, bounded upload-refusal receipts, contribution-capacity cleanup and allowances, hosted MCP delegation and outcome recording, publication restriction scoping, deployment guidance, and associated regression coverage. The final correction maps the private-replacement refusal code through the shared browser message helper.

  • Prevents limited reviewers from approving replacements for active private media.
  • Bounds refusal receipt storage while preserving replay and successful admission.
  • Tightens contribution allowance, cleanup readiness, and host-counter behavior.
  • Corrects hosted MCP scopes, metadata, delegation, and write-event outcomes.
  • Adds focused coverage confirming the private-replacement machine code is not displayed.

Reviews (2) · Last reviewed commit: "Explain private media replacement review..."

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

[AGENT]

Claude Review

Claude review for commit 1ce135597e1ef4fd5d62af883492172bffb27f00 is unavailable because the pull request was merged.

This is not a current review or approval.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bfc970a3f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread convex/_mediaReview.ts
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

PR verification report

All configured preview and verification checks passed.

Check Result Evidence
Mutation data flow PASSED Open artifact
Hosted data flow PASSED Open artifact
Public route screenshots PASSED Open artifact
Public route image diff PASSED Open artifact
Storybook screenshots PASSED Open artifact
Storybook image diff PASSED Open artifact

Changed visual baselines: none.

Updated from Baseline Checks run 35946224009, attempt 1 for 1ce1355. This comment is updated in place.

@BASIC-BIT

Copy link
Copy Markdown
Owner Author

[AGENT] @greptileai Please review the final correction from bfc970a to 1ce1355. Codex found that the private-replacement refusal displayed its machine code in the browser. BASIC approved the exact replacement sentence, and the new commit maps that code through the shared single and batch review message helper. The focused test and independent scoped review passed; the prior backend and MCP receipt behavior is unchanged. Please assess this current head for any remaining issue.

@BASIC-BIT
BASIC-BIT merged commit e65732b into main Sep 24, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant