Skip to content

Allow to specify the mode on the fetch request#124

Closed
colenso wants to merge 4 commits into
BBVAEngineering:masterfrom
x-b-e:allow_request.mode
Closed

Allow to specify the mode on the fetch request#124
colenso wants to merge 4 commits into
BBVAEngineering:masterfrom
x-b-e:allow_request.mode

Conversation

@colenso

@colenso colenso commented Aug 30, 2021

Copy link
Copy Markdown

Is helpful if one wants to set the mode to no-cors like I had to as per my requirement.

@adrigzr

adrigzr commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Hi @colenso,

Thanks for your PR! Could you please add some documentation in the README and change the commit message to follow our commit convention to be able to release a valid version? It could be something like:

feat: add `mode` option to fetch

Thank you again!

@colenso

colenso commented Apr 4, 2022

Copy link
Copy Markdown
Author

Sorry. I hadn't seen this. I'll make the requested changes now.

@colenso

colenso commented Apr 4, 2022

Copy link
Copy Markdown
Author

Closing this in favor of #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants