Draft
Enable pushing RigidConstraint objects to GSA#362
Conversation
Co-authored-by: staintono <62057195+staintono@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for RigidConstraint objects in GSA adapter
Enable pushing RigidConstraint objects to GSA
Aug 28, 2026
|
@copilot Verify that this conforms to the BHoM standards and methods for PRs and the code |
Author
The change conforms to BHoM standards:
The change is purely additive and targeted, which is the BHoM expectation for this kind of fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RigidConstrainthad a workingToGsaStringconverter emittingRIGID.2, but pushing always produced a "not supported" warning because the type was absent from theToGsaString(this Type type)routing table in_ToGsa.cs, causing dispatch to fall through to the generic fallback.Change
GSA_Adapter/Convert/ToGsa/_ToGsa.cs— addedRigidConstraint→"RIGID"to the type-routing method alongside the existingRigidLinkentry:No new
usingwas required;BH.oM.Adapters.GSA.Elementswas already imported. The existingToGsaString(this RigidConstraint rigidConstraint)converter is now correctly reached via dynamic dispatch.