Add new QuantityFamilies and To/From SI - #179
Open
Chrisshort92 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, extensible framework for unit symbol resolution and conversion between SI and other units. The main changes include the creation of a unified
UnitSpecclass, aQuantityFamilyenum to categorize physical quantities, and new methods for resolving unit symbols and performing conversions in both directions.Unit conversion framework:
UnitSpecclass to encapsulate a unit's quantity family and enumeration value, providing a standard way to represent units throughout the codebase.QuantityFamilyenum to categorize physical quantities (e.g., Length, Area, Force, etc.), supporting dispatch to the correct conversion logic.Unit symbol resolution:
Query.ResolveUnitmethod, which maps unit symbol strings (e.g., "mm", "kN") to their correspondingUnitSpec, including support for symbol aliases and error handling for unrecognized units.SI and unit conversions:
Convert.FromUnitandConvert.ToUnitextension methods, allowing conversion from a value in a specified unit symbol to SI, and vice versa, by dispatching to the correct conversion method based on the resolvedQuantityFamily. [1] [2]Issues addressed by this PR
Closes #178
Test files
Changelog
Additional comments