Vectorize summarize_gaussian_mixture to avoid slow jax concatenate - #354
Draft
DanWaxman wants to merge 2 commits into
Draft
Vectorize summarize_gaussian_mixture to avoid slow jax concatenate#354DanWaxman wants to merge 2 commits into
DanWaxman wants to merge 2 commits into
Conversation
) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0194Pb7novud9eCvxaU2vBcr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a big
jnp.stackin thesummarize_gaussian_mixturefunction of the missingness tutorial notebook. There is ostensibly a regression in stacking on minor axes injax >= 0.11.0that can cause bad runtime here. This is solved by vmapping directly instead of forming a list and stacking.