Forwarding proceeds through apply to reach default rule - #760
Conversation
eb8680
left a comment
There was a problem hiding this comment.
I'm not sure all the special-casing around ApplyOperation is right. Why do we need that type at all? Why shouldn't behavior be uniform with the sole exception of the base Operation.__apply__?
|
A version that only special cases |
|
That test seems especially suspect. Why should calling |
|
If we run the same test on |
|
I merged this because of the downstream dependency but I would like to resolve the correctness question #783 at some point. |
Closes #759
This changes the behavior of
fwdso that__apply__is called instead of reaching the default rule when forwarding from the last handler in the chain. This gives__apply__handlers a chance to see the operation. The operation default rule is now called from within the default rule of__apply__.This behavior does not apply to the
__apply__operations themselves. They are now instances ofApplyOperationto facilitate making this distinction.