fix: GenreTreeView uses h-full instead of h-screen - #26
Merged
Conversation
h-screen (100vh) assumed GenreTreeView was the only content on the page, which is never true for a real consumer (nav header, player bar, popups). Whenever it rendered below other content, its h-screen block extended past the actual visible viewport, pushing GenreTreeWheel's bottom-anchored zoom in/out controls below the fold. h-full makes it fill its parent instead; apps/playground now gives it a bounded height context, matching the flex/min-h-0 pattern grow and hear already use via their Page component. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenreTreeView's root sizes withh-screen(100vh), which is only correct if it's the sole content on the page. In every real consumer it isn't (nav header, player bar, popups share the viewport) — so the block extends past the visible viewport andGenreTreeWheel's bottom-anchored zoom in/out controls end up below the fold, present in the DOM but invisible without scrolling.h-fullso it fills its parent instead.apps/playgroundnow gives it a bounded height context (flex flex-col+min-h-0), matching the patterngrow/hear'sPagecomponent already uses..gtv-zoom-controlsrendered attop: 966in a 900px viewport (off-screen); after, attop: 814(fully visible, no scroll).Test plan
pnpm --filter @behindthemusictree/app-kit lint/build/testpnpm --filter app-kit-playground lint/build🤖 Generated with Claude Code