Allow to hide top-voters which have not played before#1522
Open
BlvckBytes wants to merge 2 commits into
Open
Conversation
Owner
|
The only issue with this is on proxy setups where the offline player check may not be accurate on each backend server. You could disable allowunjoined to prevent invalid names from coming in. Could also add a required amount of votes to be on top voter as another solution. But this could work on single server setups, but may get confusing on proxy setups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
We've recently set up a hologram displaying the names of the top 10 voters per month and ran into the issue that even mistyped names show up on there, which is rather undesirable. This probably doesn't happen on large and active servers, as typo vote-counts are tiny in comparison and fall to the very bottom, but with smaller communities, these votes will show up sooner or later.
Since I'm not familiar with the code-base much, I chose a simple solution, namely to hide entries right before sorting the top-list if the flag is enabled and they have not joined the server before. To keep behaviour unchanged relative to prior builds, the flag is default-false.
Looking forward to feedback of any kind if applicable and would be happy if we can get a feature like this in.