[UBER FORK] Enable skipping unnecessary resources linking for android_library targets - #2
Open
oliviernotteghem wants to merge 29 commits into
Open
Conversation
- acls dont work with external dependencies (i.e @foo//) - Propagate StarlarkAndroidResourcesInfo otherwise starlark rules wont be able to see those resources. - dont propagate r javas as deps. This will cause resource masking issues if two aars share the same package
…_tests Robolectric tests need three main things: - java classes - the resource classes - an archive of compiled resources For the resources components this largely boils down to simply doing the same we do for android_binary, therefore the code borrows heavily for that implementation.
Warnings go to stdout/stderr which makes it incompatible with workers
The native version of the rules have this optimization (in our internal fork). This is that implementationm, but in starlark. See https://github.sc-corp.net/Snapchat/bazel/pull/126 for more details
…r with the Lyft codebase
Bencodes
force-pushed
the
blee/fork/main
branch
from
October 31, 2023 20:12
2f5f81e to
fc8471e
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
from
December 5, 2024 18:35
b8b6ac5 to
84822bd
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
from
December 16, 2024 23:29
3afe30a to
1ea9f99
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
3 times, most recently
from
January 9, 2025 21:57
226ca01 to
b3ac29d
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
2 times, most recently
from
January 31, 2025 17:24
bfbc327 to
cae3bf0
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
from
February 4, 2025 22:17
cae3bf0 to
6fc0bf8
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
from
February 12, 2025 19:15
6fc0bf8 to
da20045
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
2 times, most recently
from
February 26, 2025 16:59
1693d40 to
80592c3
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
from
February 28, 2025 17:27
80592c3 to
a7f467e
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
4 times, most recently
from
March 26, 2025 15:17
658edb6 to
83ceb0d
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
from
March 31, 2025 20:58
83ceb0d to
d29f2d7
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
2 times, most recently
from
April 15, 2025 01:59
8f5951c to
1dc2487
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
4 times, most recently
from
May 16, 2025 22:02
9667416 to
c671e29
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
3 times, most recently
from
July 8, 2025 17:53
9489da4 to
af1cce6
Compare
Bencodes
force-pushed
the
blee/fork/main
branch
3 times, most recently
from
July 15, 2025 19:37
523fa54 to
9b4aad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implenent optimization bazelbuild/bazel#11294.
Fixes bazelbuild#157