propose guidelines change#40
Open
Huderon wants to merge 3 commits into
Open
Conversation
Member
|
@doggybootsy @DaddyBoard @TheLazySquid thoughts here? |
Member
|
I am against both |
Member
|
So it sounds like overall you don't want this change |
Contributor
|
It seems reasonable to me, even if it is a bit subjective |
Member
|
They are both just from readability standpoints, when in reality nobody is reading a theme. Additionally, with the latter one, it can actually improve speed. Like with |
Member
|
No this is not about readability, this is about performance. See the BetterDiscord docs https://docs.betterdiscord.app/themes/concepts/performance#descendant-selectors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small change made in hopes of inspiring fewer style conflicts 😭