Skip to content

Improve OpenWebUI health checks and confirmation prompts#62

Merged
BillJr99 merged 1 commit into
masterfrom
claude/upbeat-einstein-5g6bQ
May 24, 2026
Merged

Improve OpenWebUI health checks and confirmation prompts#62
BillJr99 merged 1 commit into
masterfrom
claude/upbeat-einstein-5g6bQ

Conversation

@BillJr99
Copy link
Copy Markdown
Owner

Summary

This PR enhances the reliability of OpenWebUI endpoint detection and improves the user experience of confirmation prompts by making them more explicit about expected input.

Key Changes

OpenWebUI Health Check Improvements (scripts/install_tool.sh)

  • Added HTTP-based probing as the primary method for checking OpenWebUI availability, which is more reliable than TCP port checks in minimal shell environments
  • Implements curl-based health checks with a 4-second timeout, checking both the root endpoint and the /health endpoint
  • Handles authenticated instances gracefully by accepting any HTTP response (including 401/403 status codes) as a sign of reachability
  • Falls back to raw TCP probing for environments without curl
  • Fixed port detection logic to properly default to HTTPS port 443 when the endpoint uses https:// scheme, instead of always defaulting to 8080

Confirmation Prompt Enhancement (kickoff.sh)

  • Refactored _sv_confirm() to display clearer visual hints about expected input (e.g., "Y/n" vs "y/N")
  • The hint now reflects the default value, making it immediately obvious to users what will happen if they just press Enter
  • Improved input handling by directly reading from the input stream with proper IFS handling

Implementation Details

  • The HTTP probe approach is preferred because it verifies that OpenWebUI is actually responding to requests, not just that a port is open
  • The health check gracefully degrades to TCP probing when curl is unavailable, maintaining backward compatibility
  • Confirmation prompts now use case-insensitive matching while providing case-sensitive visual feedback about defaults

https://claude.ai/code/session_01QSLjGr6qdeBEaFefyeipEk

* check_tool openwebui now does an HTTP probe via curl, treating any
  response (including 401/403) as reachable. The previous /dev/tcp
  socket check failed silently in shells without that feature, making
  install_tool falsely claim OpenWebUI wasn't running.
* _sv_confirm in kickoff.sh was rendering "[Y] [Y]" because it baked
  the default into the prompt and then _sv_read appended it again.
  It now formats a proper "Y/n" / "y/N" hint like _it_confirm does.
@BillJr99 BillJr99 merged commit 663df20 into master May 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants