Remove _ensure_git_installed function and its calls#8
Merged
Conversation
The Dockerfile already installs git as part of the base image build, so the runtime apt-get fallback in _ensure_git_installed is dead code. Remove the helper and its callers in materialize_repository and the /api/clone-and-build endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
_ensure_git_installed()function and all its call sites. This function attempted to automatically install git via apt-get if it wasn't found on PATH, but this functionality is no longer needed.Changes
_ensure_git_installed()function that checked for git availability and attempted automatic installation via apt-get_ensure_git_installed()frommaterialize_repository()_ensure_git_installed()fromclone_and_build()TestEnsureGitInstalledtest class containing three test casesRationale
The automatic git installation logic is no longer necessary, likely because:
The code now assumes git is already installed and available on PATH when repository operations are needed.
https://claude.ai/code/session_01R2Vi6NE4wGxwv6rZ2HEXji