Add smooth analytic ZBL correction - #44
Open
Pragalbhv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ZBLCorrection, a fixed (non-trainable), differentiable short-range Ziegler–Biersack–Littmark repulsive correction as a CACEoutput_module.Prevents unphysical atomic collapse at very short range without perturbing normal-bond-length behavior.
Design
ZBLCalculator(https://gitlab.com/materials-modeling/hiphive), ported to PyTorch on CACE's directed-edge graph (edge_index/shifts) so it is differentiable through CACE's existingForces/stress pipeline via autograd — no separate calculator-side implementation needed.switch_offusing the existingcace.modules.cutoff.SwitchFunction, so it only affects the short-range repulsive wall and leaves the learned + electrostatic energy untouched at normal interatomic distances.0.5per-edge weighting), batched multi-structure graphs (scatter_sumoverdata["batch"]), and periodic images (including self-loop edges through nonzero periodic shifts).output_moduleslist ahead ofFeatureAdd/Forceswith no changes to either.Usage
Tests
tests/test_zbl.py(9 tests, all passing):i→j/j→i) double-counting accounted for.switch_off.FeatureAdd→Forces.switch_offvs.cutoff).