Skip to content

Chore/repository config foundation#24

Open
yreyricord wants to merge 7 commits into
developfrom
chore/repository-config-foundation
Open

Chore/repository config foundation#24
yreyricord wants to merge 7 commits into
developfrom
chore/repository-config-foundation

Conversation

@yreyricord

@yreyricord yreyricord commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Linked issue

Closes #20

  • The linked issue is labelled status:approved, good-first-issue or help-wanted.
    Being open in the backlog is not enough on its own: only these three labels mean the scope has been triaged and approved for implementation.

What this PR changes

  • Adds .github/CODEOWNERS to route PR review automatically by file path. The current routing is a placeholder pending input from maintainers (see Notes for reviewers).
  • Adds .github/dependabot.yml to monitor Python dependencies (pyproject.toml per bps-* package), GitHub Actions versions, and Docker base images on a weekly grouped schedule. Reviewers are assigned via CODEOWNERS.
  • Adds REUSE.toml and LICENSES/Apache-2.0.txt + LICENSES/MIT.txt to make the repository REUSE-compliant via bulk annotations covering all legacy files by category.

Notes for reviewers @matteoaletti

  1. CODEOWNERS routing will needs your input.
    The CODEOWNERS file currently routes almost every path to the primary maintainer as a placeholder, because I do not yet have the GitHub handles or team names for the Scientific Module Experts (SMEs) and area maintainers. Could you tell me who should own:
  • bps-l1_* paths
  • bps-l2* paths
  • bps-stack_* paths
  • docs/** and the wiki
  1. REUSE compliance is delivered via the manifest, not inline headers.
    REUSE.toml covers all existing legacy files by category. A follow-up issue will track the progressive migration of legacy files to inline SPDX headers. Every new file added from this PR onwards is expected to carry inline headers.

  2. Three files marked as third-party with a provisional licence.
    eop.xsd, sar.xsd, and bio-l1-vrt.xsd are declared as OGC / CC-BY-4.0 on a provisional basis. We should discuss with ESA and confirm the actual licence before merge.

User-facing change

  • This PR introduces a user-facing change (API, CLI, output format, performance, documentation).

If yes, write one short release-note sentence here (it will be picked up in CHANGELOG.md):

Documentation

  • This PR modifies the documentation (Sphinx site, README, wiki, ATBD, Science Guide).
  • This PR does not modify the documentation, and no documentation update is needed.
  • This PR does not modify the documentation, but a documentation update is needed and tracked in issue #_____.

Tier rationale

The CI computes the tier automatically from the diff against the base branch. You do not assign it, but stating your expectation helps reviewers spot a mismatch quickly.

Tier Triggers Checks that run
0 Routine changes, no sensitive path touched Baseline only
1 Locked paths, SME-owned paths, marker fail, Dependabot major Baseline + Extended
2 VERSION promoted to main, designated heavy paths, manual run_heavy Baseline + Extended + Heavy

Full rules: .github/tier-policy.yml. Background: Contribution tiers in the contributor guide.

  • Expected tier: 0
  • Why: configuration-only files

AI assistance disclosure

  • No AI tools were used to prepare this PR.
  • AI tools were used. Tool(s):  

    What was generated (code, tests, documentation, commit messages): Commit messages / Comment
  • I have reviewed the generated content and take responsibility for it.

Checklist

  • This PR closes exactly one tracking issue, linked above.
  • The scope of the diff matches the approved scope in the linked issue. No drift, no extras.
  • A breaking change is explicitly flagged in the release note sentence above (if applicable).
  • The reviewer assigned has the relevant domain knowledge for this change.

CODEOWNERS currently routes every path to the single primary maintainer.
SME team handles for the L1, L2, Stack, docs and legal areas are pending
confirmation by maintainers and will be applied in a follow-up PR.

Signed-off-by: yreyricord <yoann.rey-ricord@acri-st.fr>
Weekly schedule covering Python (pyproject.toml per bps-* package)

Signed-off-by: yreyricord <yoann.rey-ricord@acri-st.fr>
REUSE.toml covers legacy files in bulk by category.

Signed-off-by: yreyricord <yoann.rey-ricord@acri-st.fr>
@yreyricord yreyricord marked this pull request as ready for review June 15, 2026 15:48
@yreyricord yreyricord requested a review from matteoaletti June 15, 2026 15:58
@yreyricord yreyricord mentioned this pull request Jun 16, 2026
11 tasks

@matteoaletti matteoaletti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked dependabot.yml file and left two comments/questions.

As far as licensing files are concerned I think that @rpiantanida should double check them as the current license files and credit files were written after iterating with ESA.

Comment thread .github/dependabot.yml
Comment thread .github/dependabot.yml
@matteoaletti matteoaletti requested a review from rpiantanida June 19, 2026 09:20
@yreyricord

Copy link
Copy Markdown
Collaborator Author

I only checked dependabot.yml file and left two comments/questions.

As far as licensing files are concerned I think that @rpiantanida should double check them as the current license files and credit files were written after iterating with ESA.

This PR does not replace the existing LICENSE.md / CREDITS.md iteration; it adds the REUSE manifest layer. I have just added the MIT and Apache Licences V2.

@yreyricord yreyricord mentioned this pull request Jun 19, 2026
11 tasks
yreyricord and others added 3 commits June 22, 2026 12:08
@yreyricord

Copy link
Copy Markdown
Collaborator Author

@matteoaletti I think it is ready to be merge :)

@matteoaletti

Copy link
Copy Markdown
Collaborator

@matteoaletti I think it is ready to be merge :)

I know this has been opened already for a while, however we are still discussing internally (@rpiantanida) because some things you would like to change in this or in the other PRs (like spdx headers) were discussed during the BPS project for a very long time. For example, if i recall correctly, SPDX were originally like you propose to change them and then it was decided to update them to the current version.

Do you think it is possible to merge at least the dependabot independently in a different PR ?

@yreyricord

Copy link
Copy Markdown
Collaborator Author

@matteoaletti I think it is ready to be merge :)

I know this has been opened already for a while, however we are still discussing internally (@rpiantanida) because some things you would like to change in this or in the other PRs (like spdx headers) were discussed during the BPS project for a very long time. For example, if i recall correctly, SPDX were originally like you propose to change them and then it was decided to update them to the current version.

Do you think it is possible to merge at least the dependabot independently in a different PR ?

Yes it is possible, but depandabot is not really a priority for the 30th workshop, it doesn't matter if we don't have it right now, I would prefer waiting :)

@rpiantanida

Copy link
Copy Markdown
Collaborator

@yreyricord I've reviewed this PR, here below my comments:

  • adding the Apache licence is ok, considering it is in some way an extension of MIT one. The only note is that we should avoid duplications with respect to LICENSE.md file currently included in the repo root (and including MIT licence text)
  • for the codeowners files, I've added some comments above
  • for the dependabot file, I don't have additional comments wrt Matteo's ones
  • for the reuse file, I'm not a big expert about this kind of file, but during the BPS development we delivered a dedicated document called SRF (Software Reuse File), containing a lot of information on this and related topics. We should check it too and ensure consistency. I can provide the doc in case you don't have it.

As an additional general comment I think we should also involve in the review someone from ESA when the PR is about licencing or similar topics. During BPS development it was Antonio V. following this, maybe we could still involve him.

@yreyricord

Copy link
Copy Markdown
Collaborator Author

R does not replace the existing LICENSE.md / CREDITS.md iteration; it adds the REUSE manifest layer. I have just added the MIT and Apache Licences V2.

Hello @rpiantanida I don't see your comments on the CODEOWNERS file.. Could you redirect me to them please ?

@rpiantanida

Copy link
Copy Markdown
Collaborator

@yreyricord

yreyricord commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

@yreyricord there are 3 comments, you can see them here https://github.com/BioPAL/BPS/pull/24/changes/BASE..b0dddaf12451ae33e9c5f8a7b88a6a91dd78fe07

Hi @rpiantanida, I can see your summary comment in the Conversation tab, but I don't see the 3 inline comments on CODEOWNERS, could you please Submit your review so they become visible to everyone? Thanks!

Comment thread .github/CODEOWNERS
Comment on lines +41 to +44
/bps-l2a_processor/ @matteoaletti
/bps-l2b_agb_processor/ @matteoaletti
/bps-l2b_fd_processor/ @matteoaletti
/bps-l2b_fh_processor/ @matteoaletti

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yreyricord we should put Emanuele Giorgi for L2*-related stuff

Comment thread .github/CODEOWNERS
Comment on lines +47 to +51
/bps-stack_binaries/ @matteoaletti
/bps-stack_cal_processor/ @matteoaletti
/bps-stack_coreg_processor/ @matteoaletti
/bps-stack_pre_processor/ @matteoaletti
/bps-stack_processor/ @matteoaletti

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yreyricord we should put Federico Boniardi for Stack-related stuff

Comment thread .github/CODEOWNERS

# ---- Documentation -----------------------------------------------------------
/README.md @matteoaletti
/CREDITS.md @matteoaletti

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yreyricord probably it is better to keep the same person for LICENSE.md and CREDITS.md (that could be you)

@rpiantanida

Copy link
Copy Markdown
Collaborator

@yreyricord sorry, my fault, I forgot to do it.. now you should see them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Add repository configuration foundation (CODEOWNERS, Dependabot, REUSE, LICENSES)

3 participants