Skip to content

Added 2 Green Themes#102

Open
AvanOsch wants to merge 3 commits into
Birkbjo:masterfrom
AvanOsch:master
Open

Added 2 Green Themes#102
AvanOsch wants to merge 3 commits into
Birkbjo:masterfrom
AvanOsch:master

Conversation

@AvanOsch

@AvanOsch AvanOsch commented Nov 5, 2020

Copy link
Copy Markdown

I manually added 2 Green Themes:

  • DisIsGreen (Adjusted copy of Discorange)
  • DarkGreen (All Discord colors shifted to the green)

Small bugfixes in "themeify.min.css":

  • In Cyborg part, a lot of colors had "\9 " at the end
  • Added a few "box-shadow" for Compatability

I manually added 2 Green Themes:
- DisIsGreen (Adjusted copy of Discorange)
- DarkGreen (All Discord colors shifted to the green)

Bugfixes in "themeify.min.css":
- In Cyborg part, a lot of colors had "\9 " at the end
- Added a few "box-shadow" for Compatability
@Birkbjo

Birkbjo commented Nov 5, 2020

Copy link
Copy Markdown
Owner

Thanks for contributing!

Please don't update or push the .min files. These should be generated when releasing. If you want to fix something, fix it in the source file.

Currently using less as it is now we are getting quite a chunky filesize on the generated css. So we should try to use https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties or something when only changing colors between themes. I will look more into this, but I'm currently not too keen on adding a lot of different themes that just change the basic colors. Should be an easier way to do this.

I will check how much this adds to the css-bundle though, but I will look into using css-variables.

@AvanOsch

AvanOsch commented Nov 5, 2020

Copy link
Copy Markdown
Author

Thanks for your response.

I actually never worked with .less files, or yarn. Also wasn't looking to install and learn it today.
I just wanted a green dark theme for my OctoPrint, which I manually copied to my install ;)

In that case, I think the .less files are pretty much the same, and will generate a green version of the discorange theme.

Custom properties would be a great option indeed, with just a couple of default colors to change from the settings menu.
Themes could then be presets of those settings.
The CSS file is needlessly chunky, and I think most users only need/want some simple color changes.

The customization menu is a great feature by the way!
Loving those tab-icons (with a fa-2x class added for bigger size)!

Should now more closely match my manually added CSS
Added Warning and Success button classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants