feat(sdk-core): add EdDSA MPCv2 external signer types and stubs#8734
Open
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Open
feat(sdk-core): add EdDSA MPCv2 external signer types and stubs#8734bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Add CustomEddsaMPCv2SigningRound{1,2,3}GeneratingFunction interfaces to
baseTypes.ts, EddsaMPCv2Round{1,2,3} entries to the ShareType enum, the
corresponding optional fields on WalletSignTransactionOptions in iWallet.ts,
and a signEddsaMPCv2TssUsingExternalSigner stub in BaseTssUtils that
throws "Method not implemented." — scaffolding only, no dispatch logic.
Ticket: WCI-373
Session-Id: 999c38eb-ed17-45f3-be26-e1239a8405a4
Task-Id: 4e34455f-37e7-4f98-b35e-4326a225e7f4
bitgo-ai-agent-dev
Bot
force-pushed
the
WCI-373-eddsa-mpcv2-external-signer-types-and-stubs
branch
from
e52557e to
5b8d995
Compare
pranishnepal
approved these changes
May 11, 2026
lcovar
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EddsaMPCv2Round1/2/3variants to theShareTypeenum inbaseTypes.tsCustomEddsaMPCv2SigningRound1/2/3GeneratingFunctioninterfaces tobaseTypes.ts, mirroring the existing ECDSACustomMPCv2Signing*interfacescustomEddsaMPCv2SigningRound{1,2,3}GenerationFunctionfields toWalletSignTransactionOptionsiniWallet.tssignEddsaMPCv2TssUsingExternalSignerstub toBaseTssUtils(throwsMethod not implemented.)No dispatch logic or implementation — purely the scaffolding for later tickets (WCI-374, WCI-375, WCI-378, WCI-379, WCI-380).
Test plan
Ticket: WCI-373
🤖 Generated with Ralph