fix: skip unregistered escrow UIDs when setting weights - #439
Merged
Conversation
Unregistered escrow hotkeys resolve to None, and numpy treats arr[None] = x as a broadcast that zeros the entire weight vector, so set_weights fell back to all-ones. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None. Indexing the weight vector withNoneis a numpy broadcast that zeros every UID, soprocess_weights_for_netuidfalls back to all-ones.NoneUIDs when buildingspecial_uidsand when assigning escrow weights. Burn is unchanged and still assigned directly.Test plan
Noneand burn still resolves to UID 135Total weight sum: 1.0000, Actual burn rate: 0.8400andset_weights on chain successfully!Made with Cursor