Reuse the shared fleet chart gap rule - #45
Open
lntutor wants to merge 1 commit into
Open
Conversation
Author
|
Current head 69e40e1 is mergeable, and I do not see any unresolved review threads or contributor-side follow-up remaining on the current PR state. This looks ready for maintainer review when convenient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #38.
Make
FleetChartdelegate gap insertion to the existingwithGapBreakshelper. This removes the duplicated median/threshold algorithm and restores one shared arbitration point for gap behavior without changing the generated chart rows.Checklist
pnpm build && pnpm typecheck && pnpm lint && pnpm testpasses locally (build first — the e2e suite runs the built daemon)@dormice/shared/sdk/clihave a changeset (pnpm changeset)