Skip to content

feat(#36): Godot HTML5 export + JavaScriptBridge → Stellar/ZK - #71

Closed
Peolite001 wants to merge 1 commit into
Bitcoindefi:mainfrom
Peolite001:feat/36-godot-html5-webbridge
Closed

feat(#36): Godot HTML5 export + JavaScriptBridge → Stellar/ZK#71
Peolite001 wants to merge 1 commit into
Bitcoindefi:mainfrom
Peolite001:feat/36-godot-html5-webbridge

Conversation

@Peolite001

Copy link
Copy Markdown

Summary

Completes the Godot HTML5 WebBridge integration. Adds EventBus signal routing, a custom export template that loads StellarGameService.js before the Godot runtime, and a StellarGameService stub for wallet/ZK operations.

Checklist

  • Security: No private keys exposed. Wallet integration is stubbed for replacement.
  • Tests: Manually verified HTML5 export flow. No automated Godot tests in repo.
  • Scope: Changes are within the scope of the issue/feature.
  • Documentation: Updated README or other docs if necessary.

Related Issues

Closes #36

- Wire WebBridge callbacks to EventBus (wallet_connected, tx_confirmed, proof_generated, web3_error)
- Add custom HTML5 export template that loads stellar_bridge.js + stellar_game_service.js before Godot runtime
- Add StellarGameService.js stub for wallet connection, commit/reveal TX, and ZK proof generation
- Update Makefile to copy all web assets to dist/ on export
- Add get_wallet_address(), commit_action(hash), reveal_action(key), export_proof(state) wrappers
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@leocagli

Copy link
Copy Markdown
Collaborator

This PR is blocked by one check, and nobody told you

Heads up: the only thing standing between this PR and a merge is the SonarCloud Code Analysis quality gate, which is red. Everything else passes.

That failure has been sitting here without anyone explaining it, which is on us, not on you.

What to do: open the SonarCloud link in the failed check (or the sonarqubecloud[bot] comment above) and look at the New Code tab. The gate only judges the lines this PR touches, so it is usually a small number of issues. The common ones:

  • coverage on new code below the threshold — add tests for the new functions
  • duplicated blocks — factor out the repeated part
  • code smells flagged as blocker/critical
  • a security hotspot that needs review

Push a fix to the same branch and the gate re-runs on its own. Comment here when it is green and it gets merged.

If you think the gate is wrong about something, say so in a comment rather than working around it — sometimes it is, and we would rather discuss it than have you contort the code.

@leocagli

Copy link
Copy Markdown
Collaborator

Cierro este PR por inactividad, y quiero explicar el criterio para que no se lea como un rechazo del trabajo.

Dos cosas se dieron juntas:

  • La rama quedó en conflicto o desactualizada contra main, así que ya no se puede mergear tal como está.
  • No hubo actividad tuya en 20 días o más: ni commits nuevos ni respuestas.

Mientras tanto main se movió, y un PR que no se puede mergear ocupa lugar en la cola de revisión de gente que sí está esperando.

Esto no es definitivo. Si querés retomarlo, reabrilo o abrí uno nuevo: hacé rebase contra main, resolvé los conflictos y avisame acá, que lo reviso. El trabajo que hiciste sigue en la rama, no se perdió nada.

Y si preferís tomar otra issue, hay varias libres etiquetadas para la campaña. Gracias por el aporte.

@leocagli leocagli closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Godot: HTML5 export + JavaScriptBridge → Stellar/ZK

2 participants