feat(quests): overland trade caravan escort and dynamic ambush engine

[angelTomo9]

Summary

Implements an overland trade caravan escort and dynamic bandit ambush mission engine for OpenAO MMORPG.

Features

• Route waypoint traversal and player protection radius enforcement
• Dynamic bandit ambush probability scaling with cargo value
• Cart integrity monitoring and delivery reward scaling
• Full unit test coverage under Vitest

[gitar-bot]

💡 Quality: Deleted tests drop coverage for radius and ambush probability

This commit removed the two existing tests "calculates ambush probability scaled by cargo value" and "pauses progression when player is beyond escort protection radius", replacing them with damage/failure tests. As a result calculateAmbushProbability and the escort-radius enforcement branch (advanceWaypoint's dist > ESCORT_PROTECTION_RADIUS path) are no longer exercised, even though the PR summary lists both as key features. Re-add coverage for the probability scaling/clamping and the radius-exceeded case alongside the new ambush tests.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Implements an overland trade caravan escort and dynamic ambush engine with updated damage and mission failure logic. Re-add coverage for the probability scaling/clamping and the radius-exceeded case as deleted tests dropped coverage for radius and ambush probability.

💡 Quality: Deleted tests drop coverage for radius and ambush probability

📄 api/src/tests/caravanEscortTrade.test.ts:17-31

This commit removed the two existing tests "calculates ambush probability scaled by cargo value" and "pauses progression when player is beyond escort protection radius", replacing them with damage/failure tests. As a result calculateAmbushProbability and the escort-radius enforcement branch (advanceWaypoint's dist > ESCORT_PROTECTION_RADIUS path) are no longer exercised, even though the PR summary lists both as key features. Re-add coverage for the probability scaling/clamping and the radius-exceeded case alongside the new ambush tests.

✅ 1 resolved

✅ Bug: Ambush trigger has no effect; cart HP and failure unused

📄 api/src/lib/caravanEscortTrade.ts:126-140
isAmbushTriggered is computed and returned but never applies any consequence: cartCurrentHp is never decremented, and isFailed is never set to true anywhere in the engine. As a result the health-scaled payout at line 136-137 always uses a 1.0 health ratio (full reward), and the advertised "cart integrity monitoring" / "delivery reward scaling" and mission-failure paths are dead. Apply ambush damage to state.cartCurrentHp when isAmbushTriggered is true, and set state.isFailed = true (returning early) when HP reaches 0.

🤖 Prompt for agents

Code Review: Implements an overland trade caravan escort and dynamic ambush engine with updated damage and mission failure logic. Re-add coverage for the probability scaling/clamping and the radius-exceeded case as deleted tests dropped coverage for radius and ambush probability.

1. 💡 Quality: Deleted tests drop coverage for radius and ambush probability
   Files: api/src/tests/caravanEscortTrade.test.ts:17-31

   This commit removed the two existing tests "calculates ambush probability scaled by cargo value" and "pauses progression when player is beyond escort protection radius", replacing them with damage/failure tests. As a result `calculateAmbushProbability` and the escort-radius enforcement branch (advanceWaypoint's `dist > ESCORT_PROTECTION_RADIUS` path) are no longer exercised, even though the PR summary lists both as key features. Re-add coverage for the probability scaling/clamping and the radius-exceeded case alongside the new ambush tests.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

---

Important

Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}