Skip to content

feat(shrines): celestial shrine pilgrimage, sacred offerings, and divine devotion tiers - #215

Open
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-celestial-shrines-1787911234562
Open

feat(shrines): celestial shrine pilgrimage, sacred offerings, and divine devotion tiers#215
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-celestial-shrines-1787911234562

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an elemental shrine pilgrimage, sacred offerings, devotion tier progression (Acolyte, Zealot, Champion, Avatar of the Gods), and Grand Pilgrim Blessings for OpenAO MMORPG.

Features

  • Elemental shrine catalog (Shrine of the Sun, Moon, Storm, Earth)
  • Sacred offerings (Incense, Holy Water, Gold Tithes) with piety progression
  • Devotion tier scaling on shrine blessing stats
  • Full 4-shrine pilgrimage tracking and Grand Pilgrim blessing unlocking
  • Full unit test coverage under Vitest

Comment thread api/src/lib/celestialShrinePilgrimage.ts
@gitar-bot

gitar-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Implements elemental shrine pilgrimage, sacred offerings, and devotion tier progression (Acolyte, Zealot, Champion, Avatar of the Gods) with Grand Pilgrim Blessings. The 24-hour pilgrimage reset on blessing claims has been fixed. No issues found.

✅ 1 resolved
Edge Case: claimGrandPilgrimBlessing skips the 24h pilgrimage reset

📄 api/src/lib/celestialShrinePilgrimage.ts:107-111 📄 api/src/lib/celestialShrinePilgrimage.ts:146-152
visitShrine resets visitedShrines after 24h, but claimGrandPilgrimBlessing never applies the same reset. A player who visited all 4 shrines can claim the Grand Pilgrim Blessing indefinitely on later days without re-doing the pilgrimage, and repeatedly (there is no consumption of visitedShrines on claim). Apply the same daily-reset check in claimGrandPilgrimBlessing (or clear/mark visitedShrines when a claim succeeds) so eligibility cannot go stale.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant