Skip to content

fix: art gaps stop being invisible walls (#6) - #40

Open
blippip69 wants to merge 1 commit into
Bitcoindefi:mainfrom
blippip69:fix/no-invisible-walls
Open

fix: art gaps stop being invisible walls (#6)#40
blippip69 wants to merge 1 commit into
Bitcoindefi:mainfrom
blippip69:fix/no-invisible-walls

Conversation

@blippip69

Copy link
Copy Markdown
Contributor

fix: art gaps stop being invisible walls (#6)

write() punched every space of sign and facade text into the grid, and four glyphs the art uses but TILES never declared fell through to NOWHERE, solid by default: about 24.9 percent of the city was unwalkable air. Sign writing now skips gap spaces while deliberate set/fill carving keeps its behaviour, and the four glyphs get honest rows in the table - carved ground open, lattice and ornaments solid. A whole-map scan asserts zero NOWHERE cells.
@gitar-bot

gitar-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Removes invisible collision walls in art gaps, ensuring player movement aligns with visual spaces. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@leocagli

Copy link
Copy Markdown
Collaborator

Merged onto current main, the tests pass. npm run lint does not:

Checking formatting...
[warn] <the new test file>
[warn] Code style issues found in the above file. Run Prettier with --write to fix.

The repository runs prettier . --check as part of npm run lint, and CI runs
lint as its own job, so this alone turns the build red.

npm run format fixes it in one pass. Nothing else needs to change; the code itself
is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants