fix: art gaps stop being invisible walls (#6) - #40
Open
blippip69 wants to merge 1 commit into
Open
Conversation
write() punched every space of sign and facade text into the grid, and four glyphs the art uses but TILES never declared fell through to NOWHERE, solid by default: about 24.9 percent of the city was unwalkable air. Sign writing now skips gap spaces while deliberate set/fill carving keeps its behaviour, and the four glyphs get honest rows in the table - carved ground open, lattice and ornaments solid. A whole-map scan asserts zero NOWHERE cells.
Code Review ✅ ApprovedRemoves invisible collision walls in art gaps, ensuring player movement aligns with visual spaces. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Collaborator
|
Merged onto current The repository runs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: art gaps stop being invisible walls (#6)