fix: carve gates into the two sealed city gardens (#5)

[blippip69]

fix: carve gates into the two sealed city gardens (#5)

[gitar-bot]

💡 Quality: Connectivity test can't prove all four gates work

The first test only asserts that >1000 interior cells are reachable from spawn. Because a garden interior is one internally-connected region, this passes as soon as any single gate connects outward, so a gate that was mis-placed or opened onto a solid obstacle would go undetected — defeating the PR's stated goal of four open approaches. The second test checks gate cells are non-solid but never checks the cell just outside each gate is walkable. Consider asserting, per side, that both the gate cell and its immediate exterior neighbor are non-solid (e.g. for the north gate also check (cxg,y-1)), so each of the four approaches is independently verified.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Carves gates into the two sealed city gardens to improve accessibility. Consider expanding the connectivity test to explicitly verify all four gates rather than just interior cell reachability.

💡 Quality: Connectivity test can't prove all four gates work

📄 test/open-city-gardens.test.js:30-44

The first test only asserts that >1000 interior cells are reachable from spawn. Because a garden interior is one internally-connected region, this passes as soon as any single gate connects outward, so a gate that was mis-placed or opened onto a solid obstacle would go undetected — defeating the PR's stated goal of four open approaches. The second test checks gate cells are non-solid but never checks the cell just outside each gate is walkable. Consider asserting, per side, that both the gate cell and its immediate exterior neighbor are non-solid (e.g. for the north gate also check (cxg,y-1)), so each of the four approaches is independently verified.

🤖 Prompt for agents

Code Review: Carves gates into the two sealed city gardens to improve accessibility. Consider expanding the connectivity test to explicitly verify all four gates rather than just interior cell reachability.

1. 💡 Quality: Connectivity test can't prove all four gates work
   Files: test/open-city-gardens.test.js:30-44

   The first test only asserts that >1000 interior cells are reachable from spawn. Because a garden interior is one internally-connected region, this passes as soon as *any single* gate connects outward, so a gate that was mis-placed or opened onto a solid obstacle would go undetected — defeating the PR's stated goal of four open approaches. The second test checks gate cells are non-solid but never checks the cell just outside each gate is walkable. Consider asserting, per side, that both the gate cell and its immediate exterior neighbor are non-solid (e.g. for the north gate also check (cxg,y-1)), so each of the four approaches is independently verified.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

---

Important

Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}

[leocagli]

Merged onto current main, the tests pass. npm run lint does not:

Checking formatting...
[warn] <the new test file>
[warn] Code style issues found in the above file. Run Prettier with --write to fix.

The repository runs prettier . --check as part of npm run lint, and CI runs
lint as its own job, so this alone turns the build red.

npm run format fixes it in one pass. Nothing else needs to change; the code itself
is fine.