fix: keep ficha and log on city screens between 64 and 90 columns (#7) - #42
fix: keep ficha and log on city screens between 64 and 90 columns (#7)#42blippip69 wants to merge 1 commit into
Conversation
…tcoindefi#7) mapScreen dropped the sidebar whenever width - SIDE_W - 5 fell below a min(mapW, 60) estimate, which silenced both panels for every terminal from 64 to 90 columns even though the map scrolls inside its pane anyway - so working actions left an identical screen while model state moved. The split layout threshold is now simply MIN_WIDTH, matching field and shop screens, with the explicit sidebar:false opt-out preserved.
| */ | ||
| function mapScreen(m) { | ||
| const tiles = (m.map && m.map.tiles) || [] | ||
| const cellW = Math.max(1, m.cellW || CELL_W) |
There was a problem hiding this comment.
💡 Quality: Unused cellW local variable left in mapScreen
The diff removed the mapW/tiles calculation that was the only consumer of the local const cellW = Math.max(1, m.cellW || CELL_W). The map pane is rendered with mapPane(m.map, w, h, { cellW: m.cellW }), which uses m.cellW directly and ignores the local clamped value, so cellW is now dead code. Remove the line to avoid confusion (and note the clamping/CELL_W fallback no longer applies here—if that fallback was intended for the pane, pass the local cellW to mapPane instead).
Was this helpful? React with 👍 / 👎
Code Review 👍 Approved with suggestions 0 resolved / 1 findingsFixes sidebar and log visibility on city screens across 64 to 90 column layouts. Consider cleaning up the unused cellW local variable left in mapScreen. 💡 Quality: Unused
|
| Auto-apply | Compact |
|
|
Important
Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
|
Merged onto current The repository runs
|
fix: keep ficha and log on city screens between 64 and 90 columns (#7)