feat: give the ruins residents and a straight east wall (#10)

[blippip69]

feat: give the ruins residents and a straight east wall (#10)

[gitar-bot]

💡 Quality: Row normalization still hides ragged art from the check

.map((row) => (row + '###').slice(0, 60) + '#') forces every dungeon row to exactly 61 chars, so defineMap()'s rectangularity check can never throw for the dungeon — the same masking behavior the comment criticizes about the old padEnd, not a fix for it. It also silently drops the rightmost column of any row longer than 61 (rows here are 62 wide, so their real east-wall column is discarded), and 60-wide rows gain a redundant double wall, leaving the interior right edge jagged by one cell despite the 'straight east wall' claim. Consider fixing the source art to a uniform width and letting defineMap() validate it, rather than reshaping rows at load time.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

CI failed: Code style check failed due to formatting issues in 2 files caught by Prettier.

Overview

1 code style failure found across 1 analyzed log, caused by Prettier formatting violations in change-related files.

Failures

Prettier Code Style Check Failed (confidence: high)

• Type: tooling
• Affected jobs: 98040986834
• Related to change: yes
• Root cause: Prettier found code style issues in lib/map.js and test/dungeon-content.test.js during the lint step.
• Suggested fix: Run Prettier locally with npx prettier . --write and commit the formatted files.

Summary

• Change-related failures: 1 code style/formatting failure
• Infrastructure/flaky failures: None
• Recommended action: Format the codebase with Prettier and push the updated commit.

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Adds residents and a straight east wall to the ruins. Consider addressing the row normalization finding to prevent ragged art from bypassing validation.

💡 Quality: Row normalization still hides ragged art from the check

📄 lib/map.js:1159-1163 📄 lib/map.js:1216-1223

.map((row) => (row + '###').slice(0, 60) + '#') forces every dungeon row to exactly 61 chars, so defineMap()'s rectangularity check can never throw for the dungeon — the same masking behavior the comment criticizes about the old padEnd, not a fix for it. It also silently drops the rightmost column of any row longer than 61 (rows here are 62 wide, so their real east-wall column is discarded), and 60-wide rows gain a redundant double wall, leaving the interior right edge jagged by one cell despite the 'straight east wall' claim. Consider fixing the source art to a uniform width and letting defineMap() validate it, rather than reshaping rows at load time.

🤖 Prompt for agents

Code Review: Adds residents and a straight east wall to the ruins. Consider addressing the row normalization finding to prevent ragged art from bypassing validation.

1. 💡 Quality: Row normalization still hides ragged art from the check
   Files: lib/map.js:1159-1163, lib/map.js:1216-1223

   `.map((row) => (row + '###').slice(0, 60) + '#')` forces every dungeon row to exactly 61 chars, so `defineMap()`'s rectangularity check can never throw for the dungeon — the same masking behavior the comment criticizes about the old `padEnd`, not a fix for it. It also silently drops the rightmost column of any row longer than 61 (rows here are 62 wide, so their real east-wall column is discarded), and 60-wide rows gain a redundant double wall, leaving the interior right edge jagged by one cell despite the 'straight east wall' claim. Consider fixing the source art to a uniform width and letting `defineMap()` validate it, rather than reshaping rows at load time.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

---

Important

Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}

[leocagli]

Merged onto current main, the tests pass. npm run lint does not:

Checking formatting...
[warn] <the new test file>
[warn] Code style issues found in the above file. Run Prettier with --write to fix.

The repository runs prettier . --check as part of npm run lint, and CI runs
lint as its own job, so this alone turns the build red.

npm run format fixes it in one pass. Nothing else needs to change; the code itself
is fine.

[leocagli]

El CI ya corrio (habilite la ejecucion, estaba esperando aprobacion de mantenedor). Dejé el detalle de todos tus PRs juntos en #50 para no repetirlo seis veces: #50