Gracefully handle keystore load failures and reinitialize SSLManager#115
Merged
Conversation
diego-ferrand
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of keystore loading and client certificate configuration in the HTTP/2 Jetty client. The main changes include better error handling when loading the JMeter keystore, improved test setup and cleanup for keystore properties, and more explicit client configuration in tests.
Keystore loading improvements
loadJMeterKeyStoremethod to handle keystore loading with error logging and fallback if loading fails, enhancing robustness and debuggability (JMeterJettySslContextFactory.java). [1] [2]Test enhancements
PKCS12, reset theSSLManager, and use a more configurableHTTP2JettyClientconstructor for better test isolation and clarity (HTTP2JettyClientTest.java).System.clearPropertyinstead of setting properties to empty strings, ensuring environment variables are properly cleared after tests (HTTP2JettyClientTest.java).