Support for running as Safari extension#51
Open
stigi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
I've spent some some time turning this into a Safari extension and put up the code over here: https://github.com/stigi/quotebacks-safari
An unsigned build can be found under the releases tab.
I used the Xcode extension converter and then cleaned up the generated project structure a bit (individual steps can be followed in the commit history of mentioned repo).
I had to fix one issue though which was that the callback when probing for the content scripts to be loaded (via sending a
"ping"message) never fired. I added a timeout which serves the same purpose in a slightly more hacky way.I'm attaching some screenshots to show the new extension in action. As a bonus I've added logic to dynamically show the correct shortcut (
alt+svsctrl+shift+s) for different browsers.What's next?
I'm thinking about releasing it to the AppStore and could do so under my paid developer account, if you folks are cool with that. Alternatively I could explore making the extension available as a signed app as a GitHub release.
Or you could release it under another App Store account.
I'm also very open for moving the code into this repo, or another repo in this org.