Embassy passports: show RECEIVED badge on My Plan when admin marks received#69
Merged
Conversation
…ceived The admin Mark Received button already set passport_received_at and removed the application from the active queue, but the user's My Plan card never read that timestamp, so it kept showing Ready (or Processing). Add a "received" branch above "ready" in the state cascade so received takes precedence, plus a navy badge and a casual "you're all set" copy block.
|
🚅 Deployed to the ruby-embassy-pr-69 environment in ruby-embassy
|
railway-app
Bot
temporarily deployed
to
ruby-embassy / ruby-embassy-pr-69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passport_received_atand removed the application from the active queue, but the user's My Plan card never read that timestamp — so it kept showing Ready (or Processing).receivedbranch abovereadyin the state cascade in_plan_item.html.erbso received takes precedence, plus a navyembassy-received-badgeand casual "you're all set" copy. Cancel × is hidden once received.plan_test.rbsets both timestamps and asserts Received wins over Ready.Test plan
bin/rails test— 361 runs, 0 failuresbin/rubocop,bin/brakeman,bin/bundler-audit,bin/importmap audit— all clean/planflips from green Ready to navy Received with cancel × hidden.