Annual Report: chart alignment, sort, version grouping, freshness, nav link#72
Merged
Conversation
…hness, nav link - Bar charts (§3 Proficiency, §1 First Ruby) now share fixed column widths so they line up regardless of label or value text. - §2 Sentiment and §3 Persona render highest→lowest by percentage. - Sentimental Ruby versions normalize to MAJOR.MINOR before tallying so 3.4 / 3.4.0 / 3.4.6 / 3.4.9 group together. - Submitting an application busts the /report cache via after_update_commit, so totals reflect new submissions immediately instead of waiting up to an hour. - Adds "Annual Report" link back to the top navbar (logged-in and logged-out, desktop and mobile).
|
🚅 Deployed to the ruby-embassy-pr-72 environment in ruby-embassy
|
railway-app
Bot
temporarily deployed
to
ruby-embassy / ruby-embassy-pr-72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
11rem 1fr 5.5rem) so labels start and values end at the same x — regardless of label length or value width.2c) normalize to MAJOR.MINOR before tallying. Verified against production:3.0+3.0.0group to 5, and3.4+3.4.0+3.4.6+3.4.9group to 5 — Ruby 3.4 is now correctly tied for Bump actions/cache from 4 to 5 #1 instead of buried at 2 mentions. The1.8.7 → 4span subtitle still renders from raw versions.EmbassyApplicationbusts the/reportcache onafter_update_commitwhen state changes tosubmitted, so new submissions surface immediately instead of waiting up to an hour.Test plan
bin/rubocop -f github— cleanbin/brakeman --no-pager— 0 security warningsbin/bundler-audit— cleanbin/importmap audit— cleanbin/rails db:test:prepare test— 362 runs, 1186 assertions, 0 failuresbin/rails test:system— 0 runs (none defined)bin/rails runnersimulation against the 30 production-extracted version strings produces the expected ranking: Ruby 3.0 (5), Ruby 3.4 (5), Ruby 1.9 (3), Ruby 2.7 (2), Ruby 3.2 (2)/reporton production, confirm bars align across both charts; confirm §2/§3 are sorted desc; confirm §2 sentimental list shows the new grouped tally; submit a fresh draft and confirm/reportbumps without waiting on the cache TTL