Support creating distinct same-participant groups - #841
Draft
kevinwmerritt wants to merge 4 commits into
Draft
kevinwmerritt wants to merge 4 commits into
kevinwmerritt wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forceNewboolean toPOST /api/v1/chat/newmethod: "private-api"chat.dbExisting behavior is unchanged when
forceNewis absent or false.Stack and dependencies
This PR targets
developmentbecause GitHub cannot base an upstream PR on a branch that exists only in a contributor fork. Once #840 merges, its commits will already be present indevelopmentand this diff will collapse to the server feature layer.Related implementation evidence
Linq documents the same externally visible matching behavior in Creating a second group with the same participants: repeating the same sender and exact recipient set returns the existing chat ID, while excluding the existing group from matching allows a separate chat ID to be created. Their documented workaround is to name the existing group before creating the next one.
That independently documented behavior is consistent with the IMCore/ChatKit roster-matching behavior addressed here. This implementation exposes an explicit forced-creation option instead of requiring callers to rename an existing group first.
API example
{ "addresses": ["person-a@example.com", "+15551234567"], "method": "private-api", "forceNew": true }messageremains optional only for forced creation. If supplied, the existing create-and-send response path is preserved.Verification
Tested on macOS 15.7.7 with the development server/helper:
chat.dbhdiutilexecution is unavailable in the current build environment