Inventory System#2
Open
dagger8243 wants to merge 5 commits into
Open
Conversation
2. Simplified it to 1 constructor with the said ideal parameters 3. Setters for the inventories' arrays 4. UUID aint final no more 5. Started on WorldStateValidator interface implementation
Contributor
Author
|
Everything but NBT stuff should be done |
BlueWeabo
reviewed
Jul 21, 2024
Owner
There was a problem hiding this comment.
missing a getter for size of inventory and max contained per slot
Contributor
Author
There was a problem hiding this comment.
those are maxSlots and maxPerSlot respectively, public fields so didnt think it needed getters
Owner
There was a problem hiding this comment.
The way that it done, input will either be overriden or override ItemOutput.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.