Skip to content

[PW_SID:1076861] [v2,1/1] Bluetooth: serialize accept_q access - #3446

Closed
BluezTestBot wants to merge 1 commit into
workflowfrom
1076861
Closed

BluezTestBot wants to merge 1 commit into
workflowfrom
1076861

Conversation

@BluezTestBot

Copy link
Copy Markdown
Owner

From: Jiexun Wang wangjiexun2025@gmail.com

bt_sock_poll() walks the accept queue without synchronization, while
child teardown can unlink the same socket and drop its last reference.

Protect accept_q with a dedicated lock for queue updates and polling.
Also rework bt_accept_dequeue() to take temporary child references under
the queue lock before dropping it and locking the child socket.

Fixes: 1da177e ("Linux-2.6.12-rc2")
Reported-by: Yifan Wu yifanwucs@gmail.com
Reported-by: Juefei Pu tomapufckgml@gmail.com
Co-developed-by: Yuan Tan yuantan098@gmail.com
Signed-off-by: Yuan Tan yuantan098@gmail.com
Suggested-by: Xin Liu bird@lzu.edu.cn
Tested-by: Ren Wei enjou1224z@gmail.com
Signed-off-by: Jiexun Wang wangjiexun2025@gmail.com
Signed-off-by: Ren Wei n05ec@lzu.edu.cn

Changes in v2:

include/net/bluetooth/bluetooth.h | 1 +
net/bluetooth/af_bluetooth.c | 85 +++++++++++++++++++++++--------
2 files changed, 66 insertions(+), 20 deletions(-)

bt_sock_poll() walks the accept queue without synchronization, while
child teardown can unlink the same socket and drop its last reference.

Protect accept_q with a dedicated lock for queue updates and polling.
Also rework bt_accept_dequeue() to take temporary child references under
the queue lock before dropping it and locking the child socket.

Fixes: 1da177e ("Linux-2.6.12-rc2")
Reported-by: Yifan Wu <yifanwucs@gmail.com>
Reported-by: Juefei Pu <tomapufckgml@gmail.com>
Co-developed-by: Yuan Tan <yuantan098@gmail.com>
Signed-off-by: Yuan Tan <yuantan098@gmail.com>
Suggested-by: Xin Liu <bird@lzu.edu.cn>
Tested-by: Ren Wei <enjou1224z@gmail.com>
Signed-off-by: Jiexun Wang <wangjiexun2025@gmail.com>
Signed-off-by: Ren Wei <n05ec@lzu.edu.cn>
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.31 seconds
Result: PENDING

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

GitLint
Desc: Run gitlint
Duration: 0.26 seconds
Result: PENDING

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

SubjectPrefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.12 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

BuildKernel
Desc: Build Kernel for Bluetooth
Duration: 25.60 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

CheckAllWarning
Desc: Run linux kernel with all warning enabled
Duration: 28.35 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

CheckSparse
Desc: Run sparse tool with linux kernel
Duration: 27.45 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

BuildKernel32
Desc: Build 32bit Kernel for Bluetooth
Duration: 25.56 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunnerSetup
Desc: Setup kernel and bluez for test-runner
Duration: 566.41 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_l2cap-tester
Desc: Run l2cap-tester with test-runner
Duration: 28.80 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_iso-tester
Desc: Run iso-tester with test-runner
Duration: 34.40 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_bnep-tester
Desc: Run bnep-tester with test-runner
Duration: 6.45 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_mgmt-tester
Desc: Run mgmt-tester with test-runner
Duration: 115.61 seconds
Result: FAIL
Output:

Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.111 seconds

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_rfcomm-tester
Desc: Run rfcomm-tester with test-runner
Duration: 10.75 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_sco-tester
Desc: Run sco-tester with test-runner
Duration: 14.63 seconds
Result: FAIL
Output:

WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_ioctl-tester
Desc: Run ioctl-tester with test-runner
Duration: 10.42 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_mesh-tester
Desc: Run mesh-tester with test-runner
Duration: 12.47 seconds
Result: FAIL
Output:

Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.703 seconds
Mesh - Send cancel - 2                               Timed out    1.994 seconds

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_smp-tester
Desc: Run smp-tester with test-runner
Duration: 8.86 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

TestRunner_userchan-tester
Desc: Run userchan-tester with test-runner
Duration: 6.87 seconds
Result: PASS

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 0.51 seconds
Result: PENDING

@BluezTestBot
BluezTestBot deleted the 1076861 branch April 4, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants