Fix issues where bi-generated exref id used instead of trialDbId in brapi endpoints#530
Open
jloux-brapi wants to merge 1 commit into
Open
Fix issues where bi-generated exref id used instead of trialDbId in brapi endpoints#530jloux-brapi wants to merge 1 commit into
jloux-brapi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2944
Matches to the submitted
trialDbIdto the trial ex ref were removed in favor of using the actual BrAPItrailDbIdexplicitly to resolve functionality mismatches.This change further cements the notion that for all intents and purposes, expId=trialDbId.
Dependencies
feature/BI-2861branch of the prod serverepic/BI-2862branch of bi-webfeature/BI-2861branch of thebrapirepo for bi-api to pick up the required changes.Testing
Test the endpoints that were changed:
Checklist: