Skip to content

Use trialDbId instead of bi-generated exref for download on top-level exp page#473

Merged
jloux-brapi merged 1 commit into
epic/BI-2862from
bug/BI-2934
Jun 22, 2026
Merged

Use trialDbId instead of bi-generated exref for download on top-level exp page#473
jloux-brapi merged 1 commit into
epic/BI-2862from
bug/BI-2934

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

Story: BI-2934

Please include a summary of the change that was made.
Use trialDbId instead of bi-generated exref for download on top-level exp page

Dependencies

None

Testing

For a created experiment with data, and subentity data, do the following

  • Click on Experiments tab for program
  • Click Download button to bring up download experiement modal
  • Choose either top-level or any sub-entity dataset to download
  • Verify download completes and looks okay

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth
  • I have run SiteImprove on pages impacted by changes

@github-actions github-actions Bot added the bug Something isn't working label Jun 17, 2026

@nickpalladino nickpalladino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Export testing works. I did notice the UUIDs saved in the ObsUnitID column are the deltabreed UUIDs and not the brapi server UUIDs. That's what's being shown in the UI experiment table as well. Is there a plan for those to eventually be the brapi UUID or to maintain separate ids?

Base automatically changed from feature/BI-2806 to epic/BI-2862 June 22, 2026 21:44
@jloux-brapi jloux-brapi merged commit 7e9c8e2 into epic/BI-2862 Jun 22, 2026
2 checks passed
@jloux-brapi jloux-brapi deleted the bug/BI-2934 branch June 22, 2026 21:45
@jloux-brapi

Copy link
Copy Markdown
Contributor Author

I did notice the UUIDs saved in the ObsUnitID column are the deltabreed UUIDs and not the brapi server UUIDs

I'd say this is work for the obs unit program cache removal tickets, not for the trials.

I do think we should change those IDs to be from the brapi side, since they are unique there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants