Skip to content

US142337 Upgrade serverless to 2.x#52

Open
mostlyfabulous wants to merge 1 commit into
Brightspace:mainfrom
mostlyfabulous:main
Open

US142337 Upgrade serverless to 2.x#52
mostlyfabulous wants to merge 1 commit into
Brightspace:mainfrom
mostlyfabulous:main

Conversation

@mostlyfabulous

@mostlyfabulous mostlyfabulous commented Aug 19, 2022

Copy link
Copy Markdown

US142338: [Telemetry Service] Upgrade serverless to 2.x to resume deployment

serverless 1.x and Node 16.x don't work well together and serverless can't deploy properly as a result.

@AntonBazhal

Copy link
Copy Markdown

This fork should be deleted. All changes we made here had been eventually merged into the original repo, so there is no reason to continue using this.

@mostlyfabulous

Copy link
Copy Markdown
Author

@AntonBazhal

Copy link
Copy Markdown

@AntonBazhal It seems there's only one important difference between the Brightspace fork and the original: ACloudGuru/serverless-plugin-aws-alerts@master...Brightspace:serverless-plugin-aws-alerts:maindiff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R164

I'm not sure I follow. Are you talking about evaluateLowSampleCountPercentile?

@mostlyfabulous

Copy link
Copy Markdown
Author

Yes, between our fork the main repo, I think the main repo doesn't accept that option

@AntonBazhal

Copy link
Copy Markdown

Yes, between our fork the main repo, I think the main repo doesn't accept that option

It does https://github.com/ACloudGuru/serverless-plugin-aws-alerts#using-percentile-statistic-for-a-metric

@mostlyfabulous

mostlyfabulous commented Aug 19, 2022

Copy link
Copy Markdown
Author

It does https://github.com/ACloudGuru/serverless-plugin-aws-alerts#using-percentile-statistic-for-a-metric

Ah okay should we make this repo read only then?

@AntonBazhal

Copy link
Copy Markdown

It does https://github.com/ACloudGuru/serverless-plugin-aws-alerts#using-percentile-statistic-for-a-metric

Ah okay should we make this repo read only then?

I think it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants