Migrate unit tests from Sinon to node:test mock API#922
Merged
Conversation
github-actions
Bot
added
the
javascript
Contributor
Coverage ReportReportReport Validation |
sarahboyd
approved these changes
Jun 23, 2026
|
🎉 This PR is included in version 6.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
d2l-github-release-tokens
Bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Sinon (
createSandbox,stub,spy,match,useFakeTimers) in the unit tests with the nativenode:testmock API (mock.method,mock.fn,mock.timers), and swaps thegithub.test.jsprocess.envstub for a direct env snapshot/restore helper.sinonremains a dependency since the integration fixtures still use it.Helps reduce dependencies but we can't get rid of mocha since I need to test it.
https://desire2learn.atlassian.net/browse/QE-2218