fix: add node:test fake timers coverage to integration fixtures#924
Merged
Conversation
github-actions
Bot
added
the
javascript
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sarahboyd
previously approved these changes
Jun 24, 2026
This comment was marked as resolved.
This comment was marked as resolved.
devpow112
changed the title
devpow112
force-pushed
the
depowell/integration-fake-timers-node
branch
from
1efc9f9 to
66472e7
Compare
devpow112
force-pushed
the
depowell/integration-fake-timers-node
branch
from
66472e7 to
9dbf5c7
Compare
Contributor
Coverage ReportReportReport Validation |
sarahboyd
approved these changes
Jun 24, 2026
|
🎉 This PR is included in version 6.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
d2l-github-release-tokens
Bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
node:testmock.timerscoverage alongside the existing Sinon fake-timers tests in the integration fixtures (node,jest,mocha,playwright,webdriverio), reorganized intosinonandnodesub-suites with the validation golden files updated to match.web-test-runneris excluded since it runs in a browser wherenode:testis unavailable.This also fixes a fringe case with playwright test running and timer faking.
https://desire2learn.atlassian.net/browse/QE-2045