Skip to content

fix: use real start times in playwright reporter under fake timers #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devpow112 merged 1 commit into from
Jun 26, 2026
Merged

fix: use real start times in playwright reporter under fake timers #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/reporters/playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createRequire } from 'node:module';
import { colors } from 'playwright-core/lib/utilsBundle';
import { escapeSpecialCharacters } from '../helpers/strings.cjs';
import { getNow, getNowISOString } from '../helpers/system.cjs';
import { getNowISOString } from '../helpers/system.cjs';

const require = createRequire(import.meta.url);

Expand Down Expand Up @@ -52,7 +52,7 @@ export default class Reporter {
#logger;
#options;
#report;
#runStarted;
#testStarted;

constructor(options = {}) {
this.#options = options;
Expand All @@ -65,8 +65,8 @@ export default class Reporter {
return;
}

this.#runStarted = getNow();
this.#logger = new PlaywrightLogger();
this.#testStarted = new Map();

try {
this.#report = new ReportBuilder('playwright', this.#logger, this.#options);
Expand All @@ -83,6 +83,20 @@ export default class Reporter {
.addContext();
}

onTestBegin(test) {
if (!this.#report || !this.#hasTests) {
return;
}

const { id, location: { file } } = test;

if (this.#report.ignoreFilePath(file)) {
return;
}

this.#testStarted.set(id, getNowISOString());
}

onTestEnd(test, result) {
if (!this.#report || !this.#hasTests) {
return;
Expand All @@ -95,12 +109,10 @@ export default class Reporter {
}

const { id, expectedStatus } = test;
const { startTime, retry, status, duration } = result;
const { retry, status, duration } = result;
const project = test.parent.project();
const name = makeTestName(test);
const started = startTime < this.#runStarted ?
getNowISOString() :
startTime.toISOString();
const started = this.#testStarted.get(id) ?? getNowISOString();
const detail = this.#report
.getDetail(id)
.setName(name)
Expand Down Expand Up @@ -129,6 +141,8 @@ export default class Reporter {
} else {
detail.setPassed({ override: isRetry });
}

this.#testStarted.delete(id);
}

onEnd(result) {
Expand Down