Skip to content

Various clips fixes - #3456

Open
shomix wants to merge 1 commit into
mainfrom
shomix-p-20260823-fixes
Open

Various clips fixes#3456
shomix wants to merge 1 commit into
mainfrom
shomix-p-20260823-fixes

Conversation

@shomix

@shomix shomix commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Every meeting in the Past list now shows who recorded it, labeled "Recorded by " (or "Recorded by Me" for your own meetings). Before this, a shared meeting with no attendees listed gave no way to tell whose notes you were looking at.
image
  • The recordings trash view could return recordings from other organizations. It now stays scoped to the current organization, like every other view.
  • The three-dot options button on a recording was nudged slightly out of alignment with its neighbors. The extra offset is removed.
  • The recording popover window now also respects the screen's width when resizing, not just its height, so it can no longer grow past the edge of a narrow monitor. Repositioning after a resize also uses the size that was just requested instead of a possibly stale one, fixing a case where the window could briefly balloon past the screen edge.
  • Starting a region recording now lets you pick which display to record on first, the same way full-screen recording already did.
  • The pending-upload and finalizing banners no longer appear while signed out.
  • The tray menu now shows the current app version.
image

@netlify

This comment has been minimized.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes and found 2 potential issues 🟡

Review Details

Code Review Summary

PR #3456 adds recording-owner attribution to meeting history rows, narrows trash recordings by organization, improves popover sizing/re-anchoring, gates upload banners on authentication, supports display selection for region capture, and adds the desktop tray version. The desktop changes are generally well-contained, and the new owner-formatting tests cover email normalization and missing owners. Risk is standard because the change crosses access-scoped data queries, UI data contracts, and native recording behavior.

Key Findings

  • 🟡 MEDIUM — Meeting owner is never populated by the meeting actions: the UI type and renderer now expect ownerEmail, but list-meetings and search-meetings do not resolve it from the linked recording, so the new attribution remains absent for persisted history and search results.
  • 🟡 MEDIUM — Search snippets suppress the recording-owner hint: a non-empty search snippet takes the fallback branch and hides the owner attribution, contrary to the intended always-visible ownership context.

🧪 Browser testing: Will run after this review (PR touches UI code)

Comment on lines 95 to +97
source?: "calendar" | "adhoc" | "manual";
participants?: AttendeeStackParticipant[];
ownerEmail?: string | null;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Populate the meeting owner field from the data sources

The route/row type now declares ownerEmail, but neither list-meetings nor search-meetings supplies it from the linked recording. As a result, persisted history and search results pass undefined to formatOwnerHint, so the new “Recorded by …” attribution and solo avatar never render. Resolve the linked recording owner in both access-scoped actions.

Fix in Builder

const ownerHint = formatOwnerHint(meeting.ownerEmail, session?.email, t);
const subtitle =
snippet?.trim() || formatParticipantNames(participants, session?.email);
snippet?.trim() ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Keep the recording owner visible with search snippets

The snippet?.trim() || ... branch renders only the search snippet whenever it is non-empty, so search results omit ownerHint. Compose the snippet/participant text and owner hint independently before joining them, so shared meeting search results retain the new recording attribution.

Fix in Builder

@github-actions

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants