Skip to content

935, 957: Adding timeline filtering and updating network statistics with timeline changes - #1688

Merged
dacowan404 merged 13 commits into
CDCgov:devfrom
glstott:935-937
Aug 12, 2026
Merged

935, 957: Adding timeline filtering and updating network statistics with timeline changes#1688
dacowan404 merged 13 commits into
CDCgov:devfrom
glstott:935-937

Conversation

@glstott

@glstott glstott commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Addresses two smaller and interrelated issues: #935 and #957.

Summary

  • Added timeline range filtering with start/end date inputs, draggable range handles, labels, selected-range styling, and a reset control.
  • Updated timeline playback so it starts within the selected range, resumes from pause, and stops at the selected range end.
  • Changed node and link visibility so timeline filtering respects both timeStart and timeEnd, which keeps network statistics aligned with the active range. This also updates the node and link color tables to keep them up to date with what is shown to the user.
  • Normalized saved-session timeline state for timeStart, timeEnd, and timeTarget when loading existing sessions.
  • Improved timeline rendering with clamped dates, synced UI/input state, better tick spacing, and safer zero-width handling.
  • Raised key table dialog z-index styling so color/shape table dialogs remain usable above timeline/UI overlays.
  • Expanded Cypress oracle support for timeline ranges and added helpers for setting ranges and interacting with visible PrimeNG overlays.
  • Added Bubble timeline regression coverage for range inputs, draggable handles, reset behavior, bounded playback, pause/resume, and visible-node/statistics alignment.

@glstott

glstott commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

Cypress tests all passed. Ready for merge.

@dacowan404

Copy link
Copy Markdown
Collaborator

I have review this PR and have a few notes, number 3 below will probably need to be asked to the team for their thoughts:

  1. When clicking on the timeline bar by default moves the Range End marker. I think being able to drag the Range Start and Range End markers is good but clicking on the timeline should move the marker indicating the current tick. I am also having issues dragging that marker in general.
  2. Node colors can be incorrect. For instance in 2D Network, MZ727698 is orange on July 5 but changes (and normally is) pink. maybe it's just orange when initially added (for 1 tick) before changing. However, I see this with other nodes and also in map and bubble [uncollapsed] views. It seems to be more persistent in these other views. Also node color table is correct.
  3. In previous implementation, nodes without temporal values (ie. timeline variable equals null) showed up at first tick of timeline. In this version, nodes without temporal values or with a value before Range Start don't show up at all. So, the question for the team is if a) we want this feature to play the same timeline but with a subset of the range to play, or b.) [this implementation] where the Range Start and End filter the nodes visible in the different views. In current implementation of option b currently leads to bubbles without center nodes (bubble view) and filters nodes and links from table view; though these specifics of the implementation can be changed.

glstott added 4 commits July 29, 2026 10:20
# Conflicts:
#	cypress/support/journey-helpers.ts
#	src/app/contactTraceCommonServices/common.service.ts
@glstott

glstott commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

After discussion, missing date nodes should be present at the start and for the entirety of the timeline view.

@glstott

glstott commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Bugs repaired. Ready for merge.

@dacowan404

Copy link
Copy Markdown
Collaborator

Thanks Guppy, it looks good. I really like the change to triangles (instead of circles) for range start/end, I think it more intuitive for users.
I merged it into the dev-update-Aug26_DC branch. When dev is ready, I'll merge this branch into dev.

@dacowan404
dacowan404 merged commit 8c0a5f8 into CDCgov:dev Aug 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants