fix: remove hardcoded base64 credential and mask it in --help-env output#112
Open
SoundMatt wants to merge 1 commit into
Open
fix: remove hardcoded base64 credential and mask it in --help-env output#112SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
DEFAULT_AUTH_REASONER_SERVER_BASE64 decoded to 'root:admin' and was printed verbatim by --help-env, leaking credentials into logs and process listings. Remove the constant entirely; require the operator to supply AUTH_REASONER_SERVER_BASE64 explicitly via the environment. In the help output, show '<set>' or '<not set>' instead of the value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DEFAULT_AUTH_REASONER_SERVER_BASE64decodes toroot:adminand is used as a fallback default credential. The--help-envflag prints its value verbatim viaHelper::getEnvVariable, leaking the credential into logs, terminal history, and process listings.Root cause
Base64 is encoding, not encryption. Shipping a default credential in source code means any system that has never had
AUTH_REASONER_SERVER_BASE64explicitly set is silently authenticated with a well-known password. Printing the resolved value in help output makes the leak observable to anyone who can run the binary or read its stdout.Fix
Remove
DEFAULT_AUTH_REASONER_SERVER_BASE64entirely and passstd::nullopttoloadSystemConfig, so the env var must be explicitly provided by the operator. In the--help-envoutput, replace the value with<set>or<not set>so the presence of the credential is communicated without exposing its contents.