Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ jobs:
with:
artifactname: Balance.xcresult
setupfirebaseemulator: true
customcommand: "firebase emulators:exec 'fastlane test'"
customcommand: |
export JAVA_HOME="$JAVA_HOME_21_arm64"
export PATH="$JAVA_HOME/bin:$PATH"
Comment thread
sebastianricaldoni marked this conversation as resolved.
java -version
firebase emulators:exec 'fastlane test'
Comment thread
sebastianricaldoni marked this conversation as resolved.
uploadcoveragereport:
name: Upload Coverage Report
needs: buildandtest
Expand Down
8 changes: 2 additions & 6 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@ only_rules:
- implicitly_unwrapped_optional
# Identifiers should use inclusive language that avoids discrimination against groups of people based on race, gender, or socioeconomic status
- inclusive_language
# If defer is at the end of its parent scope, it will be executed right where it is anyway.
- inert_defer
# Prefer using Set.isDisjoint(with:) over Set.intersection(_:).isEmpty.
- is_disjoint
# Discouraged explicit usage of the default separator.
Expand Down Expand Up @@ -217,7 +215,7 @@ only_rules:
# Operators should be surrounded by a single whitespace when they are being used.
- operator_usage_whitespace
# Operators should be surrounded by a single whitespace when defining them.
Comment thread
sebastianricaldoni marked this conversation as resolved.
- operator_whitespace
- function_name_whitespace
# Matching an enum case against an optional enum without ‘?’ is supported on Swift 5.1 and above.
- optional_enum_case_matching
# A doc comment should be attached to a declaration.
Expand Down Expand Up @@ -259,7 +257,7 @@ only_rules:
# Objective-C attribute (@objc) is redundant in declaration.
- redundant_objc_attribute
# Initializing an optional variable with nil is redundant.
- redundant_optional_initialization
- implicit_optional_initialization
# Property setter access level shouldn't be explicit if it's the same as the variable access level.
- redundant_set_access_control
# String enum values can be omitted when they are equal to the enumcase name.
Expand Down Expand Up @@ -329,8 +327,6 @@ only_rules:
- unowned_variable_capture
# Catch statements should not declare error variables without type casting.
- untyped_error_in_catch
# Unused reference in a capture list should be removed.
- unused_capture_list
# Unused parameter in a closure should be replaced with _.
- unused_closure_parameter
# Unused control flow label should be removed.
Expand Down
2 changes: 1 addition & 1 deletion Balance/Utils/BalanceExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ extension Notification.Name {
static let heartAlert = Notification.Name("heartAlert")
}

// swiftlint:disable operator_whitespace
// swiftlint:disable function_name_whitespace
// swiftlint:disable large_tuple
extension Date {
static func -(recent: Date, previous: Date) -> (hour: Int?, minute: Int?, second: Int?) {
Expand Down
2 changes: 1 addition & 1 deletion Balance/Utils/Constant.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ enum DistractMeOption: UInt32 {
maxValue += 1
}
return maxValue
}()
}()

static func randomSection() -> DistractMeOption {
// pick and return a new value
Expand Down
Loading